[stdlib] [NFC] Rename String UnsafePointer constructor args
#3741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: martinvuyk <[email protected]>
JoeLoser
approved these changes
Nov 7, 2024
|
!sync |
modularbot
added
the
imported-internally
…safeptr-constructor
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
modularbot
added a commit
to modularml/max
that referenced
this pull request
Nov 9, 2024
… args (#50486) [External] [stdlib] [NFC] Rename `String` `UnsafePointer` constructor args Rename `String` `UnsafePointer` constructor args. Part of modularml/mojo#3704. ORIGINAL_AUTHOR=martinvuyk <[email protected]> PUBLIC_PR_LINK=modularml/mojo#3741 Co-authored-by: martinvuyk <[email protected]> Closes modularml/mojo#3741 MODULAR_ORIG_COMMIT_REV_ID: 7c043cc298711e9d981a61a80693ca4b7278f4c0
modularbot
added a commit
that referenced
this pull request
Nov 9, 2024
… args (#50486) [External] [stdlib] [NFC] Rename `String` `UnsafePointer` constructor args Rename `String` `UnsafePointer` constructor args. Part of #3704. ORIGINAL_AUTHOR=martinvuyk <[email protected]> PUBLIC_PR_LINK=#3741 Co-authored-by: martinvuyk <[email protected]> Closes #3741 MODULAR_ORIG_COMMIT_REV_ID: 7c043cc298711e9d981a61a80693ca4b7278f4c0
|
Landed in e532680! Thank you for your contribution 🎉 |
modularbot
added a commit
to modularml/max
that referenced
this pull request
Dec 17, 2024
… args (#50486) [External] [stdlib] [NFC] Rename `String` `UnsafePointer` constructor args Rename `String` `UnsafePointer` constructor args. Part of modularml/mojo#3704. ORIGINAL_AUTHOR=martinvuyk <[email protected]> PUBLIC_PR_LINK=modularml/mojo#3741 Co-authored-by: martinvuyk <[email protected]> Closes modularml/mojo#3741 MODULAR_ORIG_COMMIT_REV_ID: 7c043cc298711e9d981a61a80693ca4b7278f4c0
modularbot
added a commit
that referenced
this pull request
Dec 17, 2024
… args (#50486) [External] [stdlib] [NFC] Rename `String` `UnsafePointer` constructor args Rename `String` `UnsafePointer` constructor args. Part of #3704. ORIGINAL_AUTHOR=martinvuyk <[email protected]> PUBLIC_PR_LINK=#3741 Co-authored-by: martinvuyk <[email protected]> Closes #3741 MODULAR_ORIG_COMMIT_REV_ID: 7c043cc298711e9d981a61a80693ca4b7278f4c0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
StringUnsafePointerconstructor args. Part of #3704