[stdlib] Make atomics sharable #3943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, most atomic operations required a mutable reference, which meant you had statically guarenteed mutual exclusion, which means you don't need atomics. This fixes those operations to only require an immutable reference, allowing them to be used in multiple threads. Signed-off-by: Owen Hilyard <[email protected]>
JoeLoser
approved these changes
Jan 13, 2025
|
!sync |
modularbot
added
the
imported-internally
|
!sync |
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
modularbot
pushed a commit
that referenced
this pull request
Jan 15, 2025
[External] [stdlib] Make atomics sharable Prior to this, most atomic operations required a mutable reference, which meant you had statically guarenteed mutual exclusion, which means you don't need atomics. This fixes those operations to only require an immutable reference, allowing them to be used in multiple threads. Co-authored-by: Owen Hilyard <[email protected]> Closes #3943 MODULAR_ORIG_COMMIT_REV_ID: ba2460225e7243f65d80ea397c97c9c0a77f26f6
|
Landed in eb7eb3d! Thank you for your contribution 🎉 |
jjvraw
pushed a commit
to jjvraw/mojo
that referenced
this pull request
Jan 16, 2025
[External] [stdlib] Make atomics sharable Prior to this, most atomic operations required a mutable reference, which meant you had statically guarenteed mutual exclusion, which means you don't need atomics. This fixes those operations to only require an immutable reference, allowing them to be used in multiple threads. Co-authored-by: Owen Hilyard <[email protected]> Closes modular#3943 MODULAR_ORIG_COMMIT_REV_ID: ba2460225e7243f65d80ea397c97c9c0a77f26f6 Signed-off-by: Joshua James Venter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, most atomic operations required a mutable reference, which meant you had statically guarenteed mutual exclusion, which means you don't need atomics. This fixes those operations to only require an immutable reference, allowing them to be used in multiple threads.