This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Version ordering [MOD-551] #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geometrically
approved these changes
Oct 28, 2023
Geometrically
suggested changes
Oct 28, 2023
There was a problem hiding this comment.
make sure to incorporate other routes that rely on ordering, like updating, version slug route, maven, etc
There was a problem hiding this comment.
Alright, implemented for maven and every other bit of code I could find that was previously sorting by date_published in Rust (as opposed to in SQL).
Geometrically
approved these changes
Oct 31, 2023
# Conflicts: # tests/common/asserts.rs # tests/common/environment.rs
thesuzerain
pushed a commit
that referenced
this pull request
Dec 5, 2023
* Version ordering * cargo sqlx prepare * Use version ordering for maven * Use version ordering when sorting versions in Rust (not just SQL) * Thanks clippy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.