This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
More tests #729
Merged
More tests #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geometrically
suggested changes
Oct 16, 2023
src/models/teams.rs
Outdated
| pub struct OrganizationPermissions: u64 { | ||
| const EDIT_DETAILS = 1 << 0; | ||
| const EDIT_BODY = 1 << 1; | ||
| const UNUSED = 1 << 1; // a currently unused permission, formerly EDIT_BODY |
There was a problem hiding this comment.
since this is unused why not just remove the flag?
There was a problem hiding this comment.
was trying to avod breakage in staging- but probably doesnt matter
| pub struct DummyData { | ||
| // Alpha project: |
There was a problem hiding this comment.
I think it would be better for this to use nested structs instead of one top-level one
OmegaJak
reviewed
Oct 16, 2023
src/models/teams.rs
Outdated
Comment on lines
62
to
65
| if member.accepted { | ||
| return Some(member.permissions); | ||
| } | ||
| return Some(member.permissions); |
There was a problem hiding this comment.
As written, this change has no effect on the behavior of the code - it just always returns Some(member.permissions). Did you maybe intend to only return that when the member has accepted?
There was a problem hiding this comment.
Whoops- this is an artifact from that test I commented out.
|
Looking forward to using the new templated test DB! |
Geometrically
approved these changes
Oct 17, 2023
thesuzerain
added a commit
that referenced
this pull request
Dec 5, 2023
* permissions tests * finished permissions; organization tests * clippy, fmt * post-merge fixes * teams changes * refactored to use new api * fmt, clippy * sqlx prepare * revs * revs * re-tested * re-added name * reverted to matrix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MOD-556