This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Loader + game version combo search field #622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geometrically
suggested changes
Jun 8, 2023
|
I don't believe this is possible with the existing joins? They don't have the right association between version and game version/loader. But I'll need to check and look at it again. |
|
couldn't you only join the combos and then extract the rest of the versions and loaders in the rust side of code? |
|
I think with that we'd end up with the loader ID and the game version ID, which aren't what we want. To actually convert those to the loader name and game version name we have to ask the database AFAIK. But maybe I'm misunderstanding? |
|
Superseded by modrinth/code#1778 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required backend implementation for modrinth/code#1907.
My SQL might be poor so feel free to critique.