-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes #97
base: develop
Are you sure you want to change the base?
Bug fixes #97
Conversation
This PR actually fixes a lot of JavaScript issues, can it be merged please? |
There's a failing test and a few dubious changes, but I'm sure it can be brought to shape. @lorenzomorandini would you care to review & test the code? |
Ok, I will review it |
I've been trying this version for a few days and all javascript problems seem to have gone:
|
Update: I'm working on a test suite for JS using selenium, once I am able to anchor all feature and reproduce the issues mentioned here, I this it will reduce the risk when merging this PR. |
CHANGES:
every time the add rule button was pressed.
perfectly).
'isfalse' (Also the value field becomes a readonly field, in these cases).
This was creating some issues and I thought it was a useless feature to keep in so I get rid of
that part.
and this corrected some bugs (for example: now range operator works properly).
sense to re-initiate the first rule (this problem was forcing you to use always an equal operator as
your first rule) .
'iexact' operator.