-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ps/frontend fixes #177
base: develop
Are you sure you want to change the base?
Ps/frontend fixes #177
Conversation
This pull request introduces 1 alert and fixes 3 when merging 59540fb into 5f56318 - view on LGTM.com new alerts:
fixed alerts:
|
65a91f8
to
f1fe314
Compare
This pull request introduces 1 alert and fixes 3 when merging 59540fb into 65a91f8 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 3 when merging 59540fb into 43f3503 - view on LGTM.com new alerts:
fixed alerts:
|
+ update code to use v4
+ simplify inline tabular classes
add an empty form, only if not submitting and extras required
59540fb
to
59544cd
Compare
// options added from the backend need to be removed | ||
elm.find("option").remove(); | ||
} | ||
} |
Check notice
Code scanning / CodeQL
Semicolon insertion Note
the enclosing function
}, | ||
_getCloseBtn = function(type) { | ||
if(type !== _currPopupType || !mfp.currTemplate.closeBtn) { | ||
mfp.currTemplate.closeBtn = $( mfp.st.closeMarkup.replace('%title%', mfp.st.tClose ) ); |
Check warning
Code scanning / CodeQL
Unsafe jQuery plugin Medium
'$.fn.magnificPopup' plugin
$('html').css(windowStyles); | ||
|
||
// add everything to DOM | ||
mfp.bgOverlay.add(mfp.wrap).prependTo( mfp.st.prependTo || $(document.body) ); |
Check warning
Code scanning / CodeQL
Unsafe jQuery plugin Medium
'$.fn.magnificPopup' plugin
_mfpTrigger('FirstMarkupParse', markup); | ||
|
||
if(markup) { | ||
mfp.currTemplate[type] = $(markup); |
Check warning
Code scanning / CodeQL
Unsafe jQuery plugin Medium
fix #169
fix #38