Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ps/frontend fixes #177

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Ps/frontend fixes #177

wants to merge 7 commits into from

Conversation

asfaltboy
Copy link
Member

@asfaltboy asfaltboy commented Oct 9, 2022

fix #169
fix #38

@lgtm-com
Copy link

lgtm-com bot commented Oct 9, 2022

This pull request introduces 1 alert and fixes 3 when merging 59540fb into 5f56318 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 2 for DOM text reinterpreted as HTML
  • 1 for Comparison between inconvertible types

@asfaltboy asfaltboy changed the base branch from develop to ps/119/fix-null-field October 9, 2022 12:41
@asfaltboy asfaltboy force-pushed the ps/119/fix-null-field branch from 65a91f8 to f1fe314 Compare October 9, 2022 12:44
Base automatically changed from ps/119/fix-null-field to develop October 9, 2022 12:46
@lgtm-com
Copy link

lgtm-com bot commented Oct 9, 2022

This pull request introduces 1 alert and fixes 3 when merging 59540fb into 65a91f8 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 2 for DOM text reinterpreted as HTML
  • 1 for Comparison between inconvertible types

@lgtm-com
Copy link

lgtm-com bot commented Oct 9, 2022

This pull request introduces 1 alert and fixes 3 when merging 59540fb into 43f3503 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 2 for DOM text reinterpreted as HTML
  • 1 for Comparison between inconvertible types

// options added from the backend need to be removed
elm.find("option").remove();
}
}

Check notice

Code scanning / CodeQL

Semicolon insertion Note

Avoid automated semicolon insertion (90% of all statements in
the enclosing function
have an explicit semicolon).
},
_getCloseBtn = function(type) {
if(type !== _currPopupType || !mfp.currTemplate.closeBtn) {
mfp.currTemplate.closeBtn = $( mfp.st.closeMarkup.replace('%title%', mfp.st.tClose ) );

Check warning

Code scanning / CodeQL

Unsafe jQuery plugin Medium

Potential XSS vulnerability in the
'$.fn.magnificPopup' plugin
.
$('html').css(windowStyles);

// add everything to DOM
mfp.bgOverlay.add(mfp.wrap).prependTo( mfp.st.prependTo || $(document.body) );

Check warning

Code scanning / CodeQL

Unsafe jQuery plugin Medium

Potential XSS vulnerability in the
'$.fn.magnificPopup' plugin
.
_mfpTrigger('FirstMarkupParse', markup);

if(markup) {
mfp.currTemplate[type] = $(markup);

Check warning

Code scanning / CodeQL

Unsafe jQuery plugin Medium

Potential XSS vulnerability in the
'$.fn.magnificPopup' plugin
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant