Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu Touch of UBports #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sjehuda
Copy link
Contributor

@sjehuda sjehuda commented Mar 10, 2023

No description provided.

@sjehuda
Copy link
Contributor Author

sjehuda commented Mar 10, 2023

Should createQR(); be added?

@ge0rg
Copy link
Collaborator

ge0rg commented Jan 5, 2024

"Ubuntu" in the user-agent will most probably also match users of desktop ubuntu, which should get the Linux list.

Somebody with an actual ubuntu touch device needs to provide the user-agent string from their default / fallback browser.

@mwild1 mwild1 mentioned this pull request Jun 28, 2024
@sjehuda
Copy link
Contributor Author

sjehuda commented Jun 29, 2024

If there is an issue, then I guess switch/case would solve this.

@mwild1
Copy link
Contributor

mwild1 commented Jul 2, 2024

https://askubuntu.com/a/372939/53920

This suggests we should probably check for either:

  • Ubuntu; Mobile
  • Ubuntu; Tablet

We should probably let Ubuntu; Desktop fall through to the same code as Linux.

@mwild1
Copy link
Contributor

mwild1 commented Jul 2, 2024

I guess one problem I see is that most of the UB ports have negative reviews, apart from Converse.js (which will already show up as a web client since #69 was merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants