feat(exp): concept for composable visualizations #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjungling
force-pushed
the
feat/composable-visualizations
branch
5 times, most recently
from
8036b3f
to
80c98e6
Compare
sjungling
force-pushed
the
feat/composable-visualizations
branch
from
80c98e6
to
e32ef4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of a
TextMatchTreeGridvisualization opens up an opportunity to create future visualizations that utilize this notebook in new ways by simply changing the input parameters.For example, GitHub Secrets notebook could predefine the recipe and options used to find instances of secrets and then reference the existing
TextMatchTreeGridvisualization to render the results (see: files changed)With an addition to the visualization spec and the corresponding resolution by a service, we could avoid unnecessary duplication of notebooks, a pain point we already feel. To wit, we have five notebooks related to Dependency Usage and we must create new specs, images, and notebooks for each additional build tool/package manager we wish to add.
Proposal
Extend the visualization spec to support a
visualizationfield that defines another visualization to use when generating a visualization. Resolve thumbnail images and notebooks from the visualization ID defined in thevisualizationfield and use any predefined options.