Feat/llama index image reader #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzhangpurdue
reviewed
Jul 3, 2024
modelscope_agent/rag/reader/image.py
Outdated
| api_key: str = os.getenv('DASHSCOPE_API_KEY', '')): # noqa | ||
| from openai import OpenAI | ||
|
|
||
| assert len(api_key), 'api_key is not set.' |
There was a problem hiding this comment.
all api_key shall allow user pass in during runtime, no assertion in init stage.
zzhangpurdue
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
llama index当前已有的image reader中，i2t parser 较为固定：不传入参数时为hf的固定模型，需要一定网络环境才能够下载使用；自定义时也需要遵循preprocessor+model等固定范式，无法直接调用api。
增加ImageToTextParser以解决该问题，默认可以使用识图api。
Related issue number
Checklist
pre-commit installandpre-commit run --all-filesbefore git commit, and passed lint check.