Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Subcommand Improvements #3729

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

carolynzech
Copy link
Contributor

Improvements to the list subcommand.

Resolves #3632, #3633

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@github-actions github-actions bot added the Z-BenchCI Tag a PR to run benchmark CI label Nov 19, 2024
@carolynzech carolynzech marked this pull request as ready for review November 19, 2024 16:55
@carolynzech carolynzech requested a review from a team as a code owner November 19, 2024 16:55
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can we add a test (or update an existing one) to check that the json file is printed in the output?

Similarly for the markdown table?

Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests as @zhassan-aws mentioned.

@@ -176,5 +118,42 @@ pub fn json(

serde_json::to_writer_pretty(writer, &json_obj)?;

println!("Wrote list results to {}", std::fs::canonicalize(JSON_FILENAME)?.display());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if not quiet

Ok(())
}

/// Output the results of the list subcommand.
pub fn output_list_results(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can you please move this function to the top? This is the entry point of this module, so it's easier to read the code from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List subcommand accepts redundant arguments
3 participants