Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.13 compatibility #184

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Python 3.13 compatibility #184

merged 4 commits into from
Oct 31, 2024

Conversation

freider
Copy link
Contributor

@freider freider commented Oct 31, 2024

And some test flake fixes...

Also removing uv.lock, since I think that's mostly for deployment stability of "apps" and not well suited for libs during dev that will change that file whenever you test different versions (I think?)

* hopefully fix windows timing test flake by using time.monotonic() instead of time.time()
* remove uv.lock
@freider freider requested a review from mwaskom October 31, 2024 21:02
@freider
Copy link
Contributor Author

freider commented Oct 31, 2024

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @mwaskom will follow-up review this.

@freider freider merged commit 75128fe into main Oct 31, 2024
11 checks passed
@freider freider deleted the freider/python-3.13 branch October 31, 2024 21:14
@mwaskom
Copy link
Contributor

mwaskom commented Oct 31, 2024

Nice, type stubs build on py3.13 now!

Client tests are still failing on type-stub-related tests though, so may have a little more work to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants