Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand comfyui example #742

Merged
merged 14 commits into from
May 16, 2024
Merged

expand comfyui example #742

merged 14 commits into from
May 16, 2024

Conversation

kning
Copy link
Contributor

@kning kning commented May 14, 2024

This expands the existing ComfyUI example to include things like running via API and optimizing inference performance.

This kind of breaks comfy_api.py, but figure we should move to this as the definitive guide for ComfyUI plus Modal anyway. The one thing comfy_api.py has that could be worth keeping is the get_python_workflow piece. Wasn't able to really get it working

Type of Change

  • New example
  • Example updates (Bug fixes, new features, etc.)
  • Other (changes to the codebase, but not to examples)

Checklist

  • Example is testable in synthetic monitoring system, or lambda-test: false is added to example frontmatter (---)
    • Example is tested by executing with modal run or an alternative cmd is provided in the example frontmatter (e.g. cmd: ["modal", "deploy"])
    • Example is tested by running with no arguments or the args are provided in the example frontmatter (e.g. args: ["--prompt", "Formula for room temperature superconductor:"]
  • Example is documented with comments throughout, in a Literate Programming style.
  • Example does not require third-party dependencies to be installed locally
  • Example pins its dependencies
    • Example pins container images to a stable tag, not a dynamic tag like latest
    • Example specifies a python_version for the base image, if it is used
    • Example pins all dependencies to at least minor version, ~=x.y.z or ==x.y
    • Example dependencies with version < 1 are pinned to patch version, ==0.y.z

Outside contributors

You're great! Thanks for your contribution.

@charlesfrye charlesfrye merged commit 00585b0 into main May 16, 2024
8 checks passed
@charlesfrye charlesfrye deleted the kning/comfyui-edit branch May 16, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants