Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tgi model example #575

Merged
merged 3 commits into from
Feb 8, 2024
Merged

update tgi model example #575

merged 3 commits into from
Feb 8, 2024

Conversation

kning
Copy link
Contributor

@kning kning commented Feb 8, 2024

Currently the deployed TGI example fails to return results. This was fixed by just bumping the model and image version; now cold start is only about 2 minutes.

image

Type of Change

  • New Example
  • Example updates (Bug fixes, new features, etc.)
  • Other (changes to the codebase, but not to examples)

Checklist

  • Example is testable in synthetic monitoring system, or lambda-test: false is added to example frontmatter
  • Example does not require third-party dependencies to be installed locally
  • Example pins all dependencies and specifies a python_version for the base image
  • Example is documented with comments throughout, in a Literate Programming style.

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

@kning kning changed the title Kning/update tgi model update model Feb 8, 2024
@kning kning changed the title update model update tgi model example Feb 8, 2024
@kning kning merged commit c233512 into main Feb 8, 2024
5 checks passed
@kning kning deleted the kning/update-tgi-model branch February 8, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant