Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI-223] Retry UNKNOWN status codes by default #2466

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gongy
Copy link
Contributor

@gongy gongy commented Nov 5, 2024

Describe your changes

  • Provide Linear issue reference (e.g. MOD-1234) if available.
Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.
a

Changelog

@rculbertson
Copy link
Contributor

rculbertson commented Nov 6, 2024

Since we already retry on INTERNAL errors, I think it's consistent to also retry on UNKNOWN.

Will we also fix the nginx issue @samaross found?

I'll say that in general, I'm a little hesitant to automatically retry on INTERNAL and UNKNOWN errors. If a system is failing in unexpected ways, retrying can increase load and possibly make the problem worse. So in an ideal world, I'd say it would be better to fix the root cause - but I get that's easier said than done :)

@freider
Copy link
Contributor

freider commented Nov 6, 2024

Sounds good to me. Not sure why the Windows test failed, I haven't seen that specific flake before. Just re-triggered it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants