Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Initial design for Build A/B testing epic story #114

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

mockitoguy
Copy link
Member

Suggested starting point design / implementation for #113

It's only a suggestion!!!

Perhaps this design of the workflow / task mappings is a reasonable introduction to...
more design, thinking and maybe implementing :)
@mockitoguy
Copy link
Member Author

Thank you for working on this! Let me know if it is ready for a review / initial review. Can you take a look at recent changes on the master? @mstachniuk works on e2e testing that overlaps to some degree with A/B comparison.

Copy link
Contributor

@mstachniuk mstachniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good direction! Thanks


public void apply(final Project project) {
//Step 1. Clone the repo for A/B testing
CloneGitHubRepositoryTask clone = project.getTasks().create("cloneGitHubRepository", CloneGitHubRepositoryTask.class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can reuse CloneGitRepositoryTask from master now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k, thx. I will make use of it.

clone.setTargetDir(new File(project.getBuildDir(), "abTesting/mockito/pristine"));

//Step 2. Run A test
RunTestTask runA = project.getTasks().create("runA", RunTestTask.class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can reuse RunTestReleaseTask

@epeee
Copy link
Contributor

epeee commented May 28, 2017

@szczepiq I'd kindly ask you for a initial review. Analyze comparison results is still missing, but other than that everything should be in place.
Ad Analyze comparison results: Should we create some kind of report in this task (which basically lists files which are just available in dirA or dirB and point out the differences in files which are available in both directories)?

@mockitoguy
Copy link
Member Author

Hey @epeee, I missed your earlier question, will do review as soon as I can.

@mockitoguy
Copy link
Member Author

I wanted to work on this today but I deprioritized this ticket again. Will try to find time for this soon. If I cannot make the time, we'll have to push it to after 1.0.

Sorry and thanks for patience!

@mockitoguy
Copy link
Member Author

Hey @epeee, let's deprioritize this ticket for now and revisit when e2e testing is complete after 1.0. I'm finding it hard to focus on this at the moment. In the meantime, I've added 2 more "please contribute" tickets that would be really useful for 1.0 release!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants