migrate to JUnit5 #420
Open
migrate to JUnit5 #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally I would like to do this when we switch over the main Mockito test suite (mockito/mockito#1246) and I don't think we want to move to JUnit 5 just yet. Let's discuss further in the Mockito issue before we merge any PRs related to JUnit 5. |
|
All right, no worries. If you need a helping hand on the other test code, let me know. |
|
@hennr Just curious. What are the advantages of using junit5 over junit4 (with respect to an updated junit dependency like junit 4.13.2)? |
|
@bohsen That would be the same question for me, but let's move that discussion to the Mockito issue rather than this PR, so that we can keep this PR focused on the implementation. Thanks! |
|
You folks might consider closing this one - it's been a while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you want to, but why not migrate to JUnit 5 I thought :)