FIX: gracefully handle bad patient info in edf reader #12968
Merged
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug introduced in mne-tools#11952 Code assumed that hand info would be something like "hand='0'" or "hand='1'" but in my case it was "hand='None'" which caused an error because you cannot do int('None'). This just wraps things in a try-except block
scott-huberty
requested review from
larsoner,
drammock,
agramfort and
dengemann
as code owners
mscheltienne
approved these changes
Nov 15, 2024
|
Thanks @scott-huberty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have EEG data that I saved to EDF with MNE a long time ago (maybe 2 years ago). Reading that file back used to work, but I believe a regression/bug was introduced in #11952 . Specifically this block:
mne-python/mne/io/edf/edf.py
Lines 826 to 830 in d810cc5
This code logic assumed that patient hand info would be something like
"hand=1"or"hand=2"but in my case it was"hand=None"which caused aValueErrorbecause you cannot doint('None').What does this implement/fix?
This PR just wraps things in a try-except block to gracefully handle weird cases like mine.
Additional information
I really don't know much about the EDF format, so cc'ing @paulroujansky as the author of #11952. LMK if you think this looks reasonable to you!.
Also - Perhaps no change log necessary?