Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERAM Framework #375
base: master
Are you sure you want to change the base?
ERAM Framework #375
Changes from 16 commits
9bdd3a4
53d8604
b122f21
9ae4f61
8460c43
d904616
623eabf
eae3a11
d28d5f7
d215828
148eab7
b5afb98
e21791e
5469d4f
b856bd4
26166fe
7c4f851
e0a39f0
98c83fa
35b260d
f6c898e
b6a911b
bccc414
8b6d658
7fcfa0c
bace83a
6512180
1fb93ca
305a0cd
79c5791
b8f7ec5
e5b267c
373ab72
25c1001
fa1ce52
bf5b0d1
ceee030
595a17d
3e71255
a103bd7
b6d2f53
0af528a
35137e8
8758ab9
ce45855
fa7ea10
0dfabb0
46ae73a
f621c17
5adccb5
c7f7358
85df3cd
35a207f
85181ee
6144f2f
b3c5fa7
3c660d9
3804450
6928343
44a884d
6731ce4
234c6e3
8a5eb1d
c08f5e9
e16a2ac
7c9d948
9aaa6ca
9f3cffd
95f26c9
4f840e9
efb3801
607ce68
1ebebf5
3d14cb6
2dbe146
623ab32
92acdf6
7f5d85f
516a9c0
2d37a56
9da997f
93f647b
92b9e75
d47828f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think that this is information that should be managed purely on the server; it seems unnecessarily complicated for client-side code to have to pay attention to this and then feed back information back to the server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is logging the error the right thing to do in this case? i.e. is it expected that there may not always be a flight plan, or does this case mean there's an error in the code elsewhere? If it's valid that there may be no flight plan then I assume a STARS error should be displayed to the user instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with limited reading of globals out of the computers structs (similar to what's done elsewhere for e.g.,
sim.State.Aircraft
, but setting them should probably be done through a method they provide, since the STARS code shouldn't have to potentially worry about any additional housekeeping with changing them.Also, same question as above about whether it's valid to be setting this value here since I think a sim state update will clobber it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same questions as above about what an error return value implies here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as above about the error case here.