Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Object detection models and replace existing models. (Restructuring Pt - 3) #8

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

kartikdutt18
Copy link
Member

Hey everyone,
This PR aims to remove existing examples and add model for object classification. This PR will help set structure for one of my next PRs regarding Darknet-19 and Darknet-53.
Things that I are left to do :

  1. Train the model.
  2. Upload weights on mlpack.org and make changes in load to reflect the same.
  3. Incorporate suggestions.
  4. Add documentation for this model.

{There will be another PR for documentation of dataloader with a simple tutorial.txt}.
Looking forward to your thoughts and suggestions.
Thanks a lot.

@kartikdutt18
Copy link
Member Author

kartikdutt18 commented May 23, 2020

Adding a ToDo List here :

  • Set up Training and Testing Script.
  • Host weights online.
  • Add function to unzip files.
  • By end of this PR, run all tests (instead of the single one).
  • Remove LSTM, Kaggle, and cnn etc.

@kartikdutt18
Copy link
Member Author

kartikdutt18 commented May 23, 2020

Trained all models, the tests pass locally. Let's add unzip function and host the weights online in the next two days. Fix the styling issues.

@kartikdutt18
Copy link
Member Author

kartikdutt18 commented May 24, 2020

Right, we need to link unzip function to everything, and Also upload mnist_test in mnist.tar in mlpack.org/datasets. Also host weights online. Once that is done, we can merge this after taking into account all suggestions.
Also unzip function has been added without adding any other dependency.
These messages are mostly to maintain a log of what needs to be done and can be ignored. Sorry about that.
Regards.

@birm
Copy link
Member

birm commented May 25, 2020

Should we mark this as a draft, or are you ready for review?

@kartikdutt18
Copy link
Member Author

I'll make one more commit today and then it will be ready for review.

@kartikdutt18
Copy link
Member Author

I am guessing that the invalid access in memory is maybe due to mlpack/mlpack#2314. Let see what this build outputs. Thanks a lot.

@kartikdutt18
Copy link
Member Author

Let's open 2 PR one for LeNet and one for utility function (because that is ready) and LeNet will have to wait for copy constructors I guess.

@kartikdutt18 kartikdutt18 changed the title Add Object detection models and replace existing models. (Restructuring Pt - 2) Add Object detection models and replace existing models. (Restructuring Pt - 3) May 26, 2020
@zoq zoq removed the s: unanswered label May 27, 2020
@mlpack-bot
Copy link

mlpack-bot bot commented Jun 26, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍

@mlpack-bot mlpack-bot bot added the s: stale label Jun 26, 2020
@kartikdutt18
Copy link
Member Author

Keep Open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants