Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NuGet build config files #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions mlpack.autopkg
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
nuget{
nuspec{
id=mlpack;
version: ${BUILD};
licenseUrl: "https://github.com/mlpack/mlpack/blob/master/LICENSE.txt";
iconUrl: "http://www.mlpack.org/mlpack.png";
projectUrl: "https://github.com/mlpack/mlpack";
title: "mlpack: a scalable C++ machine learning library";
description: "mlpack is an intuitive, fast, scalable C++ machine learning library, meant to be a machine learning analog to LAPACK. It aims to implement a wide array of machine learning methods and functions as a "swiss army knife" for machine learning researchers.";
summary: "Bugs Fixed";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this means, maybe just put 'mlpack is a scalable C++ machine learning library' here and just use 'mlpack' as the title?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is good idea!

releaseNotes: "";
authors: {Ryan Curtin};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm definitely not the only contributor, maybe we should wrote see http://www.mlpack.org/about.html here or something.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you are the owner 😃 and the list is too long 😆.

copyright: "Copyright (c) 2007-2017, mlpack contributors";
tags: {native, nativepackage, mlpack, windows};
}
dependencies {
packages : {
OpenBLAS/0.2.14.1,
armadillo-code/7.800.2,
boost/1.60.0,
boost_unit_test_framework-vc140/1.60.0,
boost_program_options-vc140/1.60.0,
boost_random-vc140/1.60.0,
boost_serialization-vc140/1.60.0,
boost_math_c99-vc140/1.60.0
};
}
files{
nestedInclude:{
#destination = ${d_include}mlpack;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove destination here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove destination then include folder in NuGet package doesn't get proper structure!

"build/include/**/*.hpp"
};
[x64]{
lib: "build/release/mlpack.lib";
my_bin: {
#destination:${d_bin}/.;
#add-each-file : ::nuget.[default]targets.[${condition}].CopyToOutput;
"build/release/mlpack.dll"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be mlpack.lib? Also, it looks like destination and add-each-file are unused, so maybe we can remove the parameters?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CoApp handles *.lib automatically but for bin it creates extra package called mlpack-redist. So, I had to use this simple hack trick. destination specifies content should be in bin path and add-each-file specifies bin file should be copied to output folder during build time.

};
}
}
}