Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update callbacks.md #408

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Update callbacks.md #408

merged 2 commits into from
Oct 17, 2024

Conversation

ErikDervishi03
Copy link
Contributor

Refactored the gradient clipping section in the README to reduce repetition and improve clarity

Refactored the gradient clipping section in the README to reduce repetition and improve clarity
Copy link
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ErikDervishi03! Just a couple little pedantic suggestions:

  • wrap characters to 80 per line to match the rest of the file
  • a little separation between the heading and the first paragraph (sometimes I have seen some markdown parsers hiccup on that)

doc/callbacks.md Outdated Show resolved Hide resolved
doc/callbacks.md Show resolved Hide resolved
doc/callbacks.md Show resolved Hide resolved
changes to maintain document consistency

Co-authored-by: Ryan Curtin <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@ErikDervishi03
Copy link
Contributor Author

Thanks @ErikDervishi03! Just a couple little pedantic suggestions:

  • wrap characters to 80 per line to match the rest of the file
  • a little separation between the heading and the first paragraph (sometimes I have seen some markdown parsers hiccup on that)

@rcurtin Thanks for yours suggestions. i have proceeded to commit your changes

@rcurtin
Copy link
Member

rcurtin commented Oct 17, 2024

Oops, sorry, forgot to hit the merge button. Thanks @ErikDervishi03!

@rcurtin rcurtin merged commit 882f878 into mlpack:master Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants