-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update callbacks.md #408
Update callbacks.md #408
Conversation
Refactored the gradient clipping section in the README to reduce repetition and improve clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ErikDervishi03! Just a couple little pedantic suggestions:
- wrap characters to 80 per line to match the rest of the file
- a little separation between the heading and the first paragraph (sometimes I have seen some markdown parsers hiccup on that)
changes to maintain document consistency Co-authored-by: Ryan Curtin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second approval provided automatically after 24 hours. 👍
@rcurtin Thanks for yours suggestions. i have proceeded to commit your changes |
Oops, sorry, forgot to hit the merge button. Thanks @ErikDervishi03! |
Refactored the gradient clipping section in the README to reduce repetition and improve clarity