Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding NSGA3 #406

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Adding NSGA3 #406

wants to merge 14 commits into from

Conversation

IWNMWE
Copy link
Contributor

@IWNMWE IWNMWE commented Aug 3, 2024

@IWNMWE IWNMWE marked this pull request as draft August 3, 2024 05:00
@zoq zoq marked this pull request as ready for review August 7, 2024 01:57
@zoq
Copy link
Member

zoq commented Aug 7, 2024

@mlpack-jenkins test this please

*
* @tparam MatType Type of matrix to optimize.
* @param population The elite population.
* @param objectives The set of objectives.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no objectives parameter.

* @param parentA First parent from elite population.
* @param parentB Second parent from elite population.
*/
void Crossover(MatType& childA,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lowerBound and upperBound parameter description from above, have to be added here.

Comment on lines 274 to 275
* @param child The candidate whose coordinates are being modified.
* @param objectives The set of objectives.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No child or objectives parameters, but mutationRate.

Comment on lines 528 to 535
for (size_t i = 0; i < front.size(); i++)
{
size_t ind = front[i];

pa = (calculatedObjectives[ind] - pointA);
double t = arma::dot(pa, ba) / arma::dot(ba, ba);
distancesTemp[i] = arma::accu(arma::pow((pa - t * ba), 2));
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is off here.

Copy link
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the documentation and history?

@IWNMWE
Copy link
Contributor Author

IWNMWE commented Sep 26, 2024

Hey @zoq I have added a few more changes that should make nsga3 faster especially the evaluateObjectives() which may have had a mistake leading to same function call being made multiple times, can you check it out

@zoq zoq removed the s: stale label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants