Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export MATLAB_BIN path in the makefile. #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

export MATLAB_BIN path in the makefile. #90

wants to merge 1 commit into from

Conversation

Iron-Stark
Copy link
Contributor

No description provided.

@zoq
Copy link
Member

zoq commented Jul 12, 2017

I think it might be useful to check the output of which matlab first and warn the user if the path is empty, what do you think? The Matlab path might be different for other distributions; if we set the path it might be difficult to solve potential issues without any additional insight.

@rcurtin
Copy link
Member

rcurtin commented Jul 13, 2017

I agree with that---our benchmarking setup is not necessarily the same setup others will have, so just checking if matlab is on the path first is a good step, and if it is not there then we should issue a warning that says that MATLAB_BIN is not set.

(Also, shouldn't we call it MATLAB_PATH since it is just the path to the directory containing MATLAB instead of MATLAB_BIN?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Iron-Stark @zoq @rcurtin