Added more options like min_samples_split,min_samples_leaf,max_features and max_nodes in Decision Tree scikit implementation #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
zoq
reviewed
Apr 5, 2017
methods/scikit/dtc.py
Outdated
| random_state=self.seed) | ||
| random_state=self.seed, | ||
| splitter = self.splitter, | ||
| min_samples_split = self.min_samples_split, min_weight_fraction_leaf=self.min_weight_fraction_leaf, |
There was a problem hiding this comment.
Can you use one line for each parameter, to improve the readability?
|
Done. Please Review. |
|
@mlpack-jenkins test this |
|
Not getting why the benchmark_ann file fails to compile here. Last time it was checked it compiled just fine. |
|
It compiles without any warnings on my local system while working on the same branch. |
|
@Iron-Stark Turns out the test sometimes fails when used with a small dataset, I'm not why. Let's see if testing on a bigger dataset helps. |
|
@mlpack-jenkins test this |
|
Another great contribution, thanks! |
|
Thanks. :) I am planning to implement approximate nearest neighbours using the NearPy library for the benchmarks . Will make a PR by tonight. |
Iron-Stark
pushed a commit
to Iron-Stark/benchmarks
that referenced
this pull request
Apr 6, 2017
Added more options like min_samples_split,min_samples_leaf,max_features and max_nodes in Decision Tree scikit implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rcurtin
I have added this PR in place of PR(#39) after updating my fork. Please Review.