Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

November 2024 dependency updates #318

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Nov 1, 2024

Overview

Monthly dependency updates for Account

NPM

Package     Current   Wanted   Latest  Location                 Depended by
@eslint/js   9.11.1   9.13.0   9.13.0  node_modules/@eslint/js  account
eslint       9.11.1   9.13.0   9.13.0  node_modules/eslint      account
globals      15.9.0  15.11.0  15.11.0  node_modules/globals     account
sass         1.79.4   1.80.5   1.80.5  node_modules/sass        account

Bundler

Gem                   Current  Latest   Requested  Groups
activemodel           7.2.1    7.2.2
activesupport         7.2.1    7.2.2
date                  3.3.4    3.4.0
json                  2.7.2    2.7.5
json-jwt              1.16.6   1.16.7
jwt                   2.9.1    2.9.3    >= 0       default
net-imap              0.4.16   0.5.0
nio4r                 2.7.3    2.7.4
openid_connect        2.3.0    2.3.1
parser                3.3.5.0  3.3.5.1
rack                  3.1.7    3.1.8
rexml                 3.3.8    3.3.9
rspec-core            3.13.1   3.13.2
rspec-mocks           3.13.1   3.13.2
rubocop               1.65.1   1.68.0
rubocop-ast           1.32.3   1.33.0
rubocop-performance   1.21.1   1.22.1
standard              1.40.0   1.41.1   >= 0       development, test
standard-performance  1.4.0    1.5.0
telephone_number      1.4.21   1.4.22   >= 0       default
yabeda                0.12.0   0.13.1

@erinesullivan
Copy link
Collaborator

@niquerio When I ran docker compose run web bundle exec rspec, this message came up:

/usr/local/lib/ruby/3.3.0/reline.rb:9: warning: fiddle was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add fiddle to your Gemfile or gemspec to silence this warning.
/usr/local/lib/ruby/3.3.0/bundled_gems.rb:75: warning: Rack::Logger is deprecated and will be removed in Rack 3.2.

Is this anything to be concerned about?

Everything else looks good on my end.

@niquerio
Copy link
Collaborator

niquerio commented Nov 5, 2024

@erinesullivan yeah, we should try to incorporate the Gemfile. I think I'd tried looking into fixing Rack:Logger and it wasn't the easiest. I'll give it another look.

Also, as per the message in catalog-browse I want to change us to reviewers rather than assignees in this script.

I'm also going to add the image name as an environment variable and then have it print out in the console, so that we can see what's running when we open the site and don't have to go to k9s or argocd unless something it wrong.

@niquerio
Copy link
Collaborator

niquerio commented Nov 5, 2024

I looked into both of the warnings. Both are for downstream dependencies.

Sinatra has the Rack:Logger dependency; There's a fix in the codebase that hasn't been released yet. It should be soon?

For the fiddle dependency, reline which something uses. They are working on it: ruby/reline#762

Copy link
Collaborator

@niquerio niquerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@niquerio niquerio merged commit 14310c9 into main Nov 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants