Update to 3.3; Issuer url is in env Var; fix ILLiad url #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niquerio
force-pushed
the
update-and-change-issuer
branch
from
98903a3
to
8c06026
Compare
|
Merging without a review because @erinesullivan is still out and there is a bug fix in here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
ILLiad has been upgraded, and I suspect because of that the URL endpoint got changed. This PR fixes that endpoint.
The Weblogin issuer url needs to be changed so I wanted to change it to an environment variable.
Ruby was upgraded to 3.3 on December 25 so we are upgrading to it here.