Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a minor bug in preprocess_submission #1926

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
d8f0d7e
Update generate_final_report.py
arjunsuresh Oct 31, 2024
390a8cb
Merge branch 'master' into dev
arjunsuresh Nov 7, 2024
6b1a0f8
Fix sdxl (#1911)
arjunsuresh Nov 7, 2024
a4ba51f
Fixes for filtering invalid results
arjunsuresh Nov 7, 2024
7097ef5
Merge branch 'master' into dev
arjunsuresh Nov 7, 2024
190ee41
Merge 7097ef540bfa0286c65c81fbfdcb300e6d54f770 into d3c01ed3de6618a8d…
arjunsuresh Nov 7, 2024
451b310
[Automated Commit] Format Codebase
arjunsuresh Nov 7, 2024
4c109ea
Update preprocess_submission.py
arjunsuresh Nov 7, 2024
40c1fe0
Added an option to pass in sample_ids.txt for SDXL accuracy check
arjunsuresh Nov 7, 2024
2a61df9
Merge 40c1fe0c28364b243b5944b3569000611ddf2b7d into d3c01ed3de6618a8d…
arjunsuresh Nov 7, 2024
89a2ffe
[Automated Commit] Format Codebase
arjunsuresh Nov 7, 2024
69ffdc0
Update accuracy_coco.py
arjunsuresh Nov 7, 2024
76b703b
Merge 69ffdc0aa783f9127af612a7de57c6329703c1dc into d3c01ed3de6618a8d…
arjunsuresh Nov 7, 2024
d1d642e
[Automated Commit] Format Codebase
arjunsuresh Nov 7, 2024
8d3b8ab
Fix typo
arjunsuresh Nov 7, 2024
b09b1ef
Not use default for sample_ids.txt
arjunsuresh Nov 8, 2024
857494f
Merge branch 'master' into dev
arjunsuresh Nov 12, 2024
df5049d
Update requirements.txt (#1907)
arjunsuresh Nov 14, 2024
a7e8c8a
Fix preprocess_sudbmission for a bug
arjunsuresh Nov 15, 2024
213c239
Fix conflict
arjunsuresh Nov 15, 2024
8915a90
Update submission_checker.py | Removed TEST05
arjunsuresh Nov 16, 2024
36d5b74
Merge branch 'master' into dev
arjunsuresh Nov 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tools/submission/preprocess_submission.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ def delete_empty_dirs(src):
"""
if not os.path.isdir(src):
return False

if all([delete_empty_dirs(os.path.join(src, file))
for file in os.listdir(src)]):
log.info("Removing empty dir: (%s)", src)
Expand Down Expand Up @@ -532,9 +531,11 @@ def main():
if not args.nodelete_empty_dirs:
delete_empty_dirs(os.path.join(src_dir))

run_dir = os.getcwd()
os.chdir(src_dir)

infer_scenario_results(args, config)
os.chdir(run_dir)

if not args.nodelete_empty_dirs:
delete_empty_dirs(os.path.join(src_dir))
Expand Down
9 changes: 5 additions & 4 deletions tools/submission/submission_checker.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@
"sample_index_rng_seed": 198141574272810017,
"schedule_rng_seed": 7575108116881280410,
},
# not required for v5.0+
"test05_seeds": {
# TODO: Update random seeds
"qsl_rng_seed": 2376919268182438552,
Expand Down Expand Up @@ -2880,7 +2881,7 @@ def check_compliance_dir(
compliance_perf_pass = True
compliance_perf_dir_pass = True
compliance_acc_pass = True
test_list = ["TEST01", "TEST04", "TEST05"]
test_list = ["TEST01", "TEST04"]

if model in [
"bert-99",
Expand All @@ -2899,15 +2900,15 @@ def check_compliance_dir(
]:
test_list.remove("TEST04")

if model in [
if config.version in ["v4.0", "v4.1"] and model not in [
"gptj-99",
"gptj-99.9",
"llama2-70b-99",
"llama2-70b-99.9",
"stable-diffusion-xl",
"mixtral-8x7b",
] or config.version not in ["v4.0", "v4.1"]:
test_list.remove("TEST05")
]:
test_list.append("TEST05")

if model in [
"gptj-99",
Expand Down