gmp* implemented #15
Merged
gmp* implemented #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemuyuk
reviewed
Jul 17, 2024
| def _assert_sparsity_level(self, mask: torch.Tensor, sparsity_level: float): | ||
| n_ones = mask.sum() | ||
| actual_n_ones = int(mask.numel() * (1 - sparsity_level)) | ||
| if n_ones != actual_n_ones and abs(n_ones - actual_n_ones) > 1: |
There was a problem hiding this comment.
n_ones != actual_n_ones might be redundant. Unless I'm mistaken abs(n_ones - actual_n_ones) contains the 1st condition.
There was a problem hiding this comment.
True, leaving as is for now as the plan will be to rewrite the mask calculators / pruners with sparsity as the target and then hopefully will avoid this off by one error anyways
|
Even with the one and only comment above, this seems ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.