Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calibrate() function overflows if reference resistance is big (e.g. 10kOhm) #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ebiyu
Copy link

@ebiyu ebiyu commented Jan 29, 2023

  • referenceResistor in calibrate() function has type of int, and this cause overflow if R > 32767 Ohm.
  • I changed it to long type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant