Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hub.py #754

Closed
wants to merge 1 commit into from
Closed

Update hub.py #754

wants to merge 1 commit into from

Conversation

stevendodd
Copy link
Contributor

@stevendodd stevendodd commented Feb 25, 2023

When you add and remove devices from the hub the hub can return more than the total devices..

Context

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New device
  • New product id (the device is already supported with a different id)
  • New feature (which adds functionality to an existing device)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation

Additional information

  • This PR fixes issue: fixes #
  • This PR is related to:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black.
  • The code follows the Zen of Python.
  • I am creating the Pull Request against the correct branch.
  • Documentation added/updated.

When you add and remove devices from the hub the hub can return more than the total devices..
@felipediel
Copy link
Collaborator

Thank you @stevendodd! It seems that the dids end up being duplicated when the order changes. How about we add a filter to avoid extending sub_devices with duplicate dids?

@felipediel felipediel mentioned this pull request Apr 11, 2024
13 tasks
@felipediel
Copy link
Collaborator

Closed with #790. Thanks @stevendodd!

@felipediel felipediel closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants