feat: add static Christmas theme #374
Conversation
acolombier
force-pushed
the
feat/christmas-vibe
branch
from
ef83f7c to
4b3bf96
Compare
|
Can you rebase on latest |
acolombier
force-pushed
the
feat/christmas-vibe
branch
2 times, most recently
from
5bb2547 to
497dbbd
Compare
|
Ah I had just fixed it 😅 |
acolombier
force-pushed
the
feat/christmas-vibe
branch
from
497dbbd to
e03adf7
Compare
|
@Holzhaus I have pushed my fix as it implied to use lastest version rather than reverting to a fairly old version of PyYAML - what your thought about this? Would you like to resync your fork? Edit: looks like there is more work to support newer version of PyYAML, but we should really look into it as the current version is quite vulnerable |
acolombier
force-pushed
the
feat/christmas-vibe
branch
from
e03adf7 to
28ac24c
Compare
acolombier
force-pushed
the
feat/christmas-vibe
branch
from
28ac24c to
dcb5093
Compare
|
I agree we should try to use a newer version, but I'd say the risk is rather low since we do not parse zntrust input, only stuff from this repo. And the Netlify build container is also isolated. Maybe we can switch to |
|
Re: This PR: the Mixxx logo looks slightly transformed. Aspect ratio seems to have changed, it's less wide but has roughly the same height compared to the logo without this change. But doubt someone notices without direct comparison ;) Looks cool, thanks! |
|
My fear is for someone to submit a PR to this repo, which would triggers the CI and potentially steal token to perform privilege escalation, similar to Ultralytics event last week, The risk is very low, and I believe first time contributor need CI approval so we should be fine. Still worth not letting out for too long :)
I've never used this one before, but no objection! Anything maintained would be good to me.
Glad you like it! Just need the 👍 on the hat used due to potential license risks |
Mmm that could be really an issue, can't we just draw our own? |
|
Very nice. I appreciate the work done. |
I'll see what I can do! |
|
Updated with @peineduper's asset rework as well!
We can just press merge as soon as we want to turn on the XMas Mixxx mood |
will there be some snowflakes behind the blogpost as well? |
|
Yes, you can see a live preview here |
ah ok, sorry, I thought it would only be in the upper part as in the preview, because when I click on 'news' there are no snowflakes. |
|
I'm glad yo hear you do like it! |
|
Merge? |
Co-authored-by: Emilien Colombier <[email protected]>
acolombier
force-pushed
the
feat/christmas-vibe
branch
from
e53023c to
9f20b63
Compare
|
I am already in Christmas mood, with all our efforts. Thank you.🎅🎄🌠 |
|
❄️ ❄️ ❄️ 🎁 ☃️ I ❄️ am ❄️ getting ❄️ in ❄️ the ❄️ mood ❄️ as ❄️ well 🎅🎄 🎁 ☃️ ❄️ ❄️ ❄️ ☃️ 🎁 |
|
Thanks for starting the Christmas train @daschuer ! Do you want to merge the PR now? I don't seem to have the permission to do so. |
|
@acolombier I have just granted your the access to the website and manual |
|
Love this, looks awesome! |
Adding a static Christmas theme (logo+snow fall), align with the initiative in mixxxdj/mixxx#14027
This should be revert after the 6th of Jan.
Santa hat license to be approved.