Update Numark-Mixtrack-3-scripts.js

[amakea]

Updates and bug fixes with gracious help by @Swiftb0y

[Swiftb0y]

Welcome and thanks for improving this! Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

Since this is a bugfix, can you rebase this on the 2.4 branch as well? Thank you.

[amakea]

Is their a (fairly simple) way to rebase on the website? Or would it be easier to just do another fork and submit another pull request?

[Swiftb0y]

not that I know of. I'll take care of it. ;)

[github-actions]

This PR is marked as stale because it has been open 90 days with no activity.

[amakea]

Noticed some new activity regarding this controller. I signed the contributor agreement. Are you able to rebase it @Swiftb0y do I need to give you special permission?

[endcredits33]

Thanks @amakea and @Swiftb0y for these changes, working much better now.

I propose another change regarding the PFL LED behaviour and the smartPFL variable. Currently, loading a track changes the PFL LED status on the controller, which interferes with normal usage of PFL. For example, even if PFL is off on a deck, loading a track into it will make the PFL LED light up and vice versa, creating confusion.

I've proposed a fix in #14165. What's the best way of addressing this and merging with this PR?

[amakea]

Would be happy to see your changes included @endcredits33 . I'm a beginner with github as well. Apparently the PR needs to be rebased to a different version which I don't know how to do. Perhaps @ronso0 can assist with this?

[ronso0]

@endcredits33 you just need to create a branch based on this PR (branch: https://github.com/amakea/mixxx/tree/main, btw 'main' is not a good name, try to name branches to describe the feature / bug they adress).
Then commit your fix on top.
Push to your repo.
Share the commit hash.

For @amakea being able to git cherry-pick your commit locally, they need to add your fork to their local git remotes, then fetch it git fetch <remote name>.

[amakea]

I changed the name of the branch and the pull request was closed and now I'm confused. I'm happy to just relinquish whatever "rights" I have to these code changes and hand them over to @Swiftb0y or @ronso0 because it would probably make things a lot simpler.

[ronso0]

I changed the name of the branch

Umm, just renamed it and the PR was closed instantly? You aren't working on the command line but with the Github web UI?
I didn't know that renaming the default branch of repo/fork (main in case of Mixxx) is even allowed. (ahh, you made mixtrack3 the default branch..)
I suggest learning to work with the git command line. A starter tutorial is on the wiki here and there are tons of tutorials on the web. Mixxx contributing page has instructions on how to get started.

For now, I suggest you create a new branch main from mixxxdj/mixxx/main and make that your default again.

Then open a PR from the mixtrack3 branch. Since no review happened here this is not a big loss.
Then @endcredits33 adds your repo to their remotes, creates a branch on top of your mixtrack3 branch and applies the fixup.
You can invite other Github users to your repo to collaborate. @endcredits33 can then push his branch to your repo.
And Mixxx maintainers can edit as well if you set the respective option (default on)

[amakea]

I think I did what you asked, and also invited endcredits33. Please let me know if I missed anything.
https://github.com/amakea/mixxx