Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml #168

Merged
merged 12 commits into from
Feb 27, 2023
Merged

Yaml #168

merged 12 commits into from
Feb 27, 2023

Conversation

Amndeep7
Copy link
Contributor

@Amndeep7 Amndeep7 commented Feb 21, 2023

Workflow to lint the yaml based data via yamllint, certain business rules that we have to make our code work (ex. analytics ids should be the same as their filename), and against schemas.

Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
…n user_session, and then ran yamllint against those directories and fixed them (with the line length rule turned off)

Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
…rate scripts, and current data. matching is non-strict so unexpected elements should be accepted.

Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7 Amndeep7 marked this pull request as ready for review February 21, 2023 09:40
@Amndeep7
Copy link
Contributor Author

Resolves #151 tho would appreciate confirmation that the schema is created as intended since it is based off of the current repo, which may not reflect the intended state. Example: #169 complains about some CARs missing the 'coverage' field, which I had decided to mark as optional in the schema since I did not know about the intentionality of that field being missing, nor what to fill it with if it should actually be there.

@alexiacrumpton alexiacrumpton merged commit 9a02481 into mitre-attack:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants