Website updates training #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemiller
reviewed
Jan 9, 2024
There was a problem hiding this comment.
This looks awesome so far! Just wanted to make a couple of suggestions below:
- I'd recommend adding a bit more spacing between the Video and Slides buttons in the top corner of each Module, as the Slide button appears to be default placed at the end of the first anchor element:
- There is some additional margin/padding to the left of each of the Recommended Software and Resource Links that should be removed to be in line with the bolded titles:
|
Just pushed fixes to your comments! @clemiller |
|
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Training page(s)