Update some WordPress API calls and some PHP 7 support #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added multi-site support for switch to blog functionality and updated calls to use the newer WordPress user object. Replace deprecated get_usermetadata call with get_user_meta. Check for index 'redirect_to' for $_REQUEST before calling shibboleth_session_initiator_url to avoid PHP notice. Updated deprecated call update_usermeta to update_user_metada. Replaced a call to the split() function with explode() since split is deprecated in PHP 5.3 and is no longer available in PHP 7.
ghost
mentioned this pull request
|
Hello, thank you for submitting this patch. I released version 1.8 today to resolve this and other issues and included a shoutout for your patch. I did not include the changes for "multi-site support for switch to blog functionality", as I was hoping you could provide further clarification on the purpose and use case that this is supporting. I am the new maintainer of the plugin and all further work on the plugin will be done in a new GitHub repository. If you believe that switch_to_blog change should still be included, can you please open up an issue/PR in the new repository with details on the use case? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added multi-site support for switch to blog functionality
and updated calls to use the newer WordPress user object.
Replace deprecated get_usermetadata call with get_user_meta.
Check for index 'redirect_to' for $_REQUEST before calling
shibboleth_session_initiator_url to avoid PHP notice.
Updated deprecated call update_usermeta to update_user_metada.
Replaced a call to the split() function with explode() since
split is deprecated in PHP 5.3 and is no longer available
in PHP 7.