Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kword] Rewrite plugin in kotlin #224

Merged
merged 9 commits into from
Aug 14, 2024
Merged

[Kword] Rewrite plugin in kotlin #224

merged 9 commits into from
Aug 14, 2024

Conversation

npresseault
Copy link
Member

Description

Rewrite kword plugin in kotlin.
The gradle DSL also gets an update.

Gradle plugin DSL changed. All properties are now lazy.
Instead of

  translationFile = file("src/commonMain/resources/translations/translation.en.json")
  enumClassName = "com.mirego.sample.KWordTranslation"
  generatedDir = file("src/commonMain/generated")

Do this

  translationFile.set(file("src/commonMain/resources/translations/translation.en.json"))
  enumClassName.set("com.mirego.sample.KWordTranslation")
  generatedDir.set(file("src/commonMain/generated"))

Motivation and Context

Using kotlin will make it easier to maintain it. Aditionaly, we were using non lazy properties gradle which could result in non optimal gradle builds.

How Has This Been Tested?

Ran the plugin in the local kword sample.
Writing tests is something that would be a nice addition but it does require some additional setup to test the gradle task itself.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@npresseault npresseault merged commit 0ee2688 into master Aug 14, 2024
1 check passed
@npresseault npresseault deleted the kword-enums branch August 14, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants