[Android] Allow the VMDTextStyleProvider to use Composable functions #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the VMDTextStyleProvider to call Composable functions. This will allow the TextStyle to use colours that change depending on the app theme.
Thi
Description
Make VMDTextStyleProvider functions Composable so we're able to call Composable functions.
Motivation and Context
The current implementation only allows a
TextStyle
to use static colours. In the Sports (TSN/RDS) app, we want the styles to use colours that change depending on the app theme (like use a light font colour if the app is in dark theme or vice-versa)How Has This Been Tested?
I made the
SampleTextStyleProvider
in the sample app useLocalContentColor.current
(which is a Composable) when building theTextStyle
forSampleTextStyleResource.HIGHLIGHTED
.Types of changes
Note on breaking change: The minor breaking change is that you will have to add
@Composable
on override function of classes that implementsVMDTextStyleProvider
.