Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formal verification for equivalence checking between MuGrpahs #141

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

wmdi
Copy link
Collaborator

@wmdi wmdi commented Nov 19, 2024

Description of changes:
It is consistent with the probabilistic verifier in the gated_mlp workload.

For the attention workloads, it accepts more mugraphs than the probabilistic one. I manually checked the mugraphs and think they are correct (I might be wrong since it is not easy to check the correctness of a mugraph).

There are also performance issues:

  1. The verifier currently can only check one mugraph at a time for the ease of implementation, which is a bottleneck in some workloads;
  2. We can fine tune the time/resource limit of the solver to achieve the balance between solver accuracy and performance.

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

  • Closes #

@wmdi wmdi requested a review from jiazhihao November 19, 2024 08:11
@jiazhihao
Copy link
Member

It's surprisingly that it accepts more muGraphs than probabilistic verification. If you think these muGraphs are correct, this means there is a bug in our fingerprint calculation logic. Do you think we can look into one such example during the meeting today?

@wmdi
Copy link
Collaborator Author

wmdi commented Nov 19, 2024

Let's merge #142 first and resolve the conflict in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants