feat: 广告合并-bugfix #314 #1287
Merged
feat: 广告合并-bugfix #314 #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
部署成功，请访问地址获取编译代码。 Built with commit ca4b902 |
|
部署成功，请访问地址获取编译代码。 Built with commit 87540ff |
huanghuiquan
approved these changes
Nov 15, 2018
|
关联到issue为：小说节约广告成本 #1272 |
VenyXiong
approved these changes
Nov 15, 2018
| for (var key in config.paths) { | ||
| if (config.paths.hasOwnProperty(key)) { | ||
| config.paths[key] = config.domain + config.paths[key]; | ||
| var customConfig = JSON.parse(JSON.stringify(config)); |
There was a problem hiding this comment.
这是啥操作？为什么需要stringify然后在parse?
hehexiaoxue
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
提交pr时需要关联issue，请大家遵守
1272
1、升级点 （清晰准确的描述升级的功能点）
广告合并bugfix-为防止config中带的地址有多余的domain域名前缀
2、影响范围 （描述该需求上线会影响什么功能）
使用了custom的页面
3、自测 checklist
chrome
4、需要覆盖的场景和case
5、自测机型和浏览器
温馨提示：非 mip-extensions 仓库的组件请在组件平台提交，否则一律打回；