Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add Bubble Tea Dependency and TUI Command #47

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

eharris128
Copy link
Contributor

What

  • Add a mint tui command
  • Add Bubble Tea as a dependency

Why

  • Setup the dependency for supporting a TUI for images
  • Propose potential initial entrypoint for supporting a TUI

How Tested

  • mint tui
  • Press up and down keys
  • Observe change in the number
  • Press q to quit

Testing Path Two:

  • mint
  • tui
  • Up & down keys
  • Press Q to return to mint CLI

Demo:

tui.zip

Signed-off-by: Evan Harris <[email protected]>
Signed-off-by: Evan Harris <[email protected]>
Signed-off-by: Evan Harris <[email protected]>
@@ -0,0 +1,20 @@
package tui
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing... i got confused initially when i saw main.go thinking that it has the main function and its own main package. Renaming the file to tui.go would eliminate the confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. Will update thank you.

@kcq
Copy link
Contributor

kcq commented Aug 30, 2024

tui doesn't need to be exposed through the interactive prompt mode. The idea there is to have one or the other. It's ok to keep tui in the prompt mode. Not a big deal.

@eharris128 eharris128 changed the title Draft: Add Bubble Tea Dependency and TUI Commadn Draft: Add Bubble Tea Dependency and TUI Command Sep 2, 2024
@eharris128
Copy link
Contributor Author

tui doesn't need to be exposed through the interactive prompt mode. The idea there is to have one or the other. It's ok to keep tui in the prompt mode. Not a big deal.

Would the preferred pattern be:
CLI: mint images --tui
CLI -> Interactive: mint images --tui

Then for debug I would follow the same pattern?

With this approach there would be no tui command. Only a flag per command with tui support.

@kcq kcq merged commit 17e7978 into mintoolkit:master Sep 2, 2024
3 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants