APS-1775: Update booking confirmation screen #2277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froddd
force-pushed
the
feature/APS-1775-confirm-space-booking
branch
from
424a3c7 to
b6bf14f
Compare
This does a few things: - Ensures the booking confirmation flow uses the arrival date and departure date submitted, rather than relying on filter start date and duration - Removes the `apType` parameter as it is not used - Updates the booking confirmation template to show relevent information - Refactors a lot of the flow to present occupancy view with retained filters where relevant
froddd
force-pushed
the
feature/APS-1775-confirm-space-booking
branch
from
b6bf14f to
1947cf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
https://dsdmoj.atlassian.net/browse/APS-1775
Changes in this PR
Implements design and content updates to the 'Confirm booking' page.
Under the hood, this ensures the booking flow relies on the arrival and departure dates entered on the Occupancy view page, rather than recalculating those based on a start date and duration. The path for the confirmation screen has been rewritten to include the premises ID, which ensures a 404 is returned if this ID is invalid/doesn't exist.
The occupancy filter query parameters are carried over to the confirmation page to ensure the back link functions correctly.
The
apTypeparameter is now removed, as it is no longer used beyond the initial suitability search.Screenshots of UI changes
Before
After