Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ilm rule edit for --expire-all-object-versions #5101

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Dec 30, 2024

Editing a rule with --expire-all-object-versions should be applied to existing rule properly

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Motivation and Context

How to test this PR?

mc ilm rule add --expire-days "365"  sitea/bucket2
mc ilm rule edit --id ctpdqf3b61a9d2elqqv0 --expire-days "365" --expire-all-object-versions sitea/bucket2

ExpiredObjectAllVersions: true should be set in the policy after the edit

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Editing a rule with --expire-all-object-versions should be applied
to existing rule properly
@poornas poornas requested review from krisis and shtripat December 30, 2024 18:02
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshavardhana harshavardhana merged commit bf7b5f6 into minio:master Jan 2, 2025
5 checks passed
@harshavardhana
Copy link
Member

@poornas please send this to miniohq/ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants