Add sizes to mc admin trace #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` Regular trace: 2024-06-03T14:18:37.303 [STORAGE] storage.ReadXL 127.0.0.1:9001 e:\data\distxl\s1\d3 warp-benchmark-bucket pz9WSPPj/4.TnpU8KEot9t4zl66.rnd 538.3µs 1003 B With -v: 127.0.0.1:9001 [STORAGE storage.ReadXL] [2024-06-03T14:14:51.680] e:\data\distxl\s1\d3 warp-benchmark-bucket yvhiOPYp/117.hjDOOH6KmAhtC0Ty.rnd total-errs-availability=0 total-errs-timeout=0 0s 1003 B With -stats Duration: 21s ∙∙● Call Count RPM Avg Time Min Time Max Time Avg TTFB Max TTFB Avg Size Errors storage.ReadXL 15808 (67.2%) 44344.8 429µs 0s 69.9984ms 0s 0s 1.2 KiB 0 storage.Delete 3088 (13.1%) 8662.5 2.056ms 9.7075ms 305.0662ms 0s 0s - 3 http stats: Duration: 14s ∙∙● Call Count RPM Avg Time Min Time Max Time Avg TTFB Max TTFB Avg Size Errors s3.GetObject 4532 (44.1%) 19502.8 1.121ms 267.5µs 67.9369ms 1.098ms 67.9369ms ↓77 B ↑1000 B 0 s3.HeadObject 3028 (29.4%) 13030.6 1.031ms 506.8µs 62.9893ms 0s 0s ↓77 B 0 s3.PutObject 1711 (16.6%) 7363.1 21.109ms 2.5496ms 181.8214ms 9µs 10.6771ms ↓1.3 KiB ↑0 B 0 s3.DeleteObject 1008 (9.8%) 4337.8 56.204ms 1.5859ms 411.1034ms 1.185ms 175.1619ms ↓77 B ↑4 B 0 s3.DeleteMultipleObjects 1 (0.0%) 4.3 316.358ms 316.3584ms 316.3584ms 315.306ms 315.3055ms ↓23 KiB ↑24 KiB 0 ``` Backwards compatible, but will start displaying non-zero after: minio/minio#19851 and minio/minio#19864
shtripat
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backwards compatible, but will start displaying non-zero after: minio/minio#19851 and minio/minio#19864
Still, sizes does not make sense for all trace types.
How to test this PR?
Run server with PRs above. Do
mc admin trace ALIAS.Types of changes