Fix regression that causes mc idp ldap accesskey create to error
#4938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadmeste
reviewed
May 20, 2024
what is the error? |
|
Error was |
| @@ -165,8 +167,7 @@ func accessKeyCreateOpts(ctx *cli.Context, targetUser string) madmin.AddServiceA | |||
| } | |||
| } else if expDurVal != 0 { | |||
| exp = time.Now().Add(expDurVal) | |||
There was a problem hiding this comment.
how is this value passed? I see that this being ignored.
|
#4939 should address, the code itself was not readable using too many variables to do one thing. I have restructured things and made it more readable PTAL lets close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Fix error that causes any
mc idp ldap accesskey createwithout a specified expiration time to failMotivation and Context
How to test this PR?
Types of changes
Checklist: