Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the percent of pool used #4910

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Fix the percent of pool used #4910

merged 2 commits into from
Apr 29, 2024

Conversation

fanzy618
Copy link
Contributor

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

When you run the command 'mc admin rebalance status,' it shows the used space as a percentage. The server returns a floating-point number between 0 and 1. To express this number as a percentage, you should multiply it by 100 and then add the '%' symbol. I believe the multiplication step has been omitted.

Motivation and Context

How to test this PR?

Types of changes

  • [* ] Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@shtripat shtripat requested a review from krisis April 25, 2024 07:19
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiuker
Copy link
Contributor

jiuker commented Apr 29, 2024

@harshavardhana cc

@jiuker jiuker requested a review from harshavardhana April 29, 2024 02:23
@harshavardhana harshavardhana merged commit 770097b into minio:master Apr 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants