Remove yara from sst_csi_client_tools #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ptoscano please do the needful. |
|
While removing it from sst_client_tools is correct, it will drop it entirely from the distro. yara must be in a workload to be shipped. If yara belongs to sst_insights, then please move it to that workload. |
|
@ptoscano It belongs to platmgmt-ins-security which isn't listed as a group in the config directory. But it is a rover group: https://rover.redhat.com/groups/group/platmgmt-ins-security |
As I said, it must belong to a RHEL SST. |
yselkowitz
requested changes
Nov 28, 2024
mhuth
force-pushed
the
remove_yara_sst_csi_client_tools
branch
from
d415a05 to
79e04e3
Compare
yselkowitz
requested changes
Nov 29, 2024
configs/sst_insights.yaml
Outdated
Comment on lines
9
to
14
| package_placeholders: | ||
| - srpm_name: yara | ||
| rpms: | ||
| - rpm_name: yara | ||
| description: yara | ||
| dependencies: [] |
mhuth
force-pushed
the
remove_yara_sst_csi_client_tools
branch
from
79e04e3 to
1a85db0
Compare
yselkowitz
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.