-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust Rewrite #215
Draft
mindstorm38
wants to merge
65
commits into
main
Choose a base branch
from
rust-rewrite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Rust Rewrite #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
=======================================
Coverage ? 63.60%
=======================================
Files ? 20
Lines ? 3314
Branches ? 0
=======================================
Hits ? 2108
Misses ? 1206
Partials ? 0 ☔ View full report in Codecov by Sentry. |
mindstorm38
force-pushed
the
rust-rewrite
branch
from
June 30, 2024 10:34
b4826aa
to
abd4ea8
Compare
…to mojang installer.
… of issue regarding launch. Now using default Java 8 if not specified in the version metadata.
…resources assets, need more researches.
…erarchy are fetch excluded.
… real own dependencies.
…e to parse dates in metadata
mindstorm38
force-pushed
the
rust-rewrite
branch
from
October 8, 2024 11:27
067d590
to
2a5ac68
Compare
… documented some API.
…cy logging, with colors when supported by the terminal.
…f Windows with the default behavior on Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tracking pull request for the work-in-progress Rust rewrite, this will take a long, long time!
If you want to give feedback on the concept, not the code, please go check #196.
Feel free to review the code!
TODO: