add Cover notation

mimmi20 · Jan 18, 2025 · 96d56f0 · 96d56f0
1 parent 9bc9de7
commit 96d56f0
Show file tree

Hide file tree

Showing 114 changed files with 260 additions and 550 deletions.
diff --git a/phpunit-integration.xml b/phpunit-integration.xml
@@ -28,6 +28,7 @@
     enforceTimeLimit="false"
     executionOrder="default"
     resolveDependencies="true"
+    requireCoverageMetadata="false"
     colors="true"
     cacheDirectory="./.reports/.coverage-cache"
     columns="123"

diff --git a/phpunit.xml b/phpunit.xml
@@ -27,6 +27,7 @@
     enforceTimeLimit="false"
     executionOrder="default"
     resolveDependencies="true"
+    requireCoverageMetadata="true"
     colors="true"
     cacheDirectory="./.reports/.coverage-cache"
     columns="119"

diff --git a/src/Detector.php b/src/Detector.php
@@ -45,12 +45,12 @@
 use UaResult\Os\OsInterface;
 use UnexpectedValueException;
 
-use function array_change_key_case;
 use function array_filter;
 use function array_map;
 use function assert;
 use function explode;
 use function is_array;
+use function is_int;
 use function is_string;
 use function mb_strpos;
 use function mb_strtolower;
@@ -60,8 +60,6 @@
 use function str_contains;
 use function trim;
 
-use const CASE_LOWER;
-
 final readonly class Detector implements DetectorInterface
 {
     /**
@@ -557,6 +555,10 @@ private function getPlatformData(array $filteredHeaders, string | null $platform
             }
         }
 
+        if (!$platformVersion instanceof VersionInterface) {
+            $platformVersion = null;
+        }
+
         return new Os(
             name: null,
             marketingName: null,

diff --git a/tests/DetectorTest/Bits/BrowserTest.php b/tests/DetectorTest/Bits/BrowserTest.php
@@ -15,10 +15,12 @@
 
 use BrowserDetector\Bits\Browser;
 use Override;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\ExpectationFailedException;
 use PHPUnit\Framework\TestCase;
 
+#[CoversClass(Browser::class)]
 final class BrowserTest extends TestCase
 {
     private Browser $object;

diff --git a/tests/DetectorTest/Bits/OsTest.php b/tests/DetectorTest/Bits/OsTest.php
@@ -15,11 +15,13 @@
 
 use BrowserDetector\Bits\Os;
 use Override;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\ExpectationFailedException;
 use PHPUnit\Framework\TestCase;
 
+#[CoversClass(Os::class)]
 final class OsTest extends TestCase
 {
     private Os $object;

diff --git a/tests/DetectorTest/Cache/CacheTest.php b/tests/DetectorTest/Cache/CacheTest.php
@@ -14,6 +14,7 @@
 namespace BrowserDetectorTest\Cache;
 
 use BrowserDetector\Cache\Cache;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\ExpectationFailedException;
 use PHPUnit\Framework\TestCase;
@@ -23,6 +24,7 @@
 use function assert;
 use function serialize;
 
+#[CoversClass(Cache::class)]
 final class CacheTest extends TestCase
 {
     /**

diff --git a/tests/DetectorTest/Detector10Test.php b/tests/DetectorTest/Detector10Test.php
@@ -21,6 +21,7 @@
 use BrowserDetector\Version\VersionBuilderFactoryInterface;
 use BrowserDetector\Version\VersionBuilderInterface;
 use BrowserDetector\Version\VersionInterface;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\TestCase;
 use Psr\Log\LoggerInterface;
@@ -39,6 +40,7 @@
 use UaResult\Os\Os;
 use UnexpectedValueException;
 
+#[CoversClass(Detector::class)]
 final class Detector10Test extends TestCase
 {
     /**

diff --git a/tests/DetectorTest/Detector1Test.php b/tests/DetectorTest/Detector1Test.php
@@ -17,6 +17,7 @@
 use BrowserDetector\Detector;
 use BrowserDetector\Loader\DeviceLoaderFactoryInterface;
 use BrowserDetector\Version\VersionBuilderFactoryInterface;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\TestCase;
 use Psr\Log\LoggerInterface;
@@ -29,6 +30,7 @@
 use UaRequest\RequestBuilderInterface;
 use UnexpectedValueException;
 
+#[CoversClass(Detector::class)]
 final class Detector1Test extends TestCase
 {
     /**

diff --git a/tests/DetectorTest/Detector2Test.php b/tests/DetectorTest/Detector2Test.php
@@ -21,6 +21,7 @@
 use BrowserDetector\Version\VersionBuilderFactoryInterface;
 use BrowserDetector\Version\VersionBuilderInterface;
 use BrowserDetector\Version\VersionInterface;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\TestCase;
 use Psr\Log\LoggerInterface;
@@ -44,6 +45,7 @@
 use function assert;
 use function sprintf;
 
+#[CoversClass(Detector::class)]
 final class Detector2Test extends TestCase
 {
     /**

diff --git a/tests/DetectorTest/Detector3Test.php b/tests/DetectorTest/Detector3Test.php
@@ -17,6 +17,7 @@
 use BrowserDetector\Detector;
 use BrowserDetector\Loader\DeviceLoaderFactoryInterface;
 use BrowserDetector\Version\VersionBuilderFactoryInterface;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\TestCase;
 use Psr\Log\LoggerInterface;
@@ -30,6 +31,7 @@
 use UaRequest\RequestBuilderInterface;
 use UnexpectedValueException;
 
+#[CoversClass(Detector::class)]
 final class Detector3Test extends TestCase
 {
     /**

diff --git a/tests/DetectorTest/Detector4Test.php b/tests/DetectorTest/Detector4Test.php
@@ -24,6 +24,7 @@
 use BrowserDetector\Version\VersionBuilderFactoryInterface;
 use BrowserDetector\Version\VersionBuilderInterface;
 use BrowserDetector\Version\VersionInterface;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\TestCase;
 use Psr\Log\LoggerInterface;
@@ -44,6 +45,7 @@
 use UaResult\Os\Os;
 use UnexpectedValueException;
 
+#[CoversClass(Detector::class)]
 final class Detector4Test extends TestCase
 {
     /**

diff --git a/tests/DetectorTest/Detector5Test.php b/tests/DetectorTest/Detector5Test.php
@@ -23,6 +23,7 @@
 use BrowserDetector\Version\VersionBuilderFactoryInterface;
 use BrowserDetector\Version\VersionBuilderInterface;
 use BrowserDetector\Version\VersionInterface;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\TestCase;
 use Psr\Log\LoggerInterface;
@@ -41,6 +42,7 @@
 use UaResult\Os\Os;
 use UnexpectedValueException;
 
+#[CoversClass(Detector::class)]
 final class Detector5Test extends TestCase
 {
     /**

diff --git a/tests/DetectorTest/Detector6Test.php b/tests/DetectorTest/Detector6Test.php
@@ -19,6 +19,7 @@
 use BrowserDetector\Loader\DeviceLoaderFactoryInterface;
 use BrowserDetector\Version\NullVersion;
 use BrowserDetector\Version\VersionBuilderFactoryInterface;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\TestCase;
 use Psr\Log\LoggerInterface;
@@ -37,6 +38,7 @@
 use UaResult\Os\Os;
 use UnexpectedValueException;
 
+#[CoversClass(Detector::class)]
 final class Detector6Test extends TestCase
 {
     /**

diff --git a/tests/DetectorTest/Detector7Test.php b/tests/DetectorTest/Detector7Test.php
@@ -21,6 +21,7 @@
 use BrowserDetector\Version\VersionBuilderFactoryInterface;
 use BrowserDetector\Version\VersionBuilderInterface;
 use BrowserDetector\Version\VersionInterface;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\TestCase;
 use Psr\Log\LoggerInterface;
@@ -40,6 +41,7 @@
 use UaResult\Os\Os;
 use UnexpectedValueException;
 
+#[CoversClass(Detector::class)]
 final class Detector7Test extends TestCase
 {
     /**

diff --git a/tests/DetectorTest/Detector8Test.php b/tests/DetectorTest/Detector8Test.php
@@ -21,6 +21,7 @@
 use BrowserDetector\Version\VersionBuilderFactoryInterface;
 use BrowserDetector\Version\VersionBuilderInterface;
 use BrowserDetector\Version\VersionInterface;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\TestCase;
 use Psr\Log\LoggerInterface;
@@ -40,6 +41,7 @@
 use UaResult\Os\Os;
 use UnexpectedValueException;
 
+#[CoversClass(Detector::class)]
 final class Detector8Test extends TestCase
 {
     /**

diff --git a/tests/DetectorTest/Detector9Test.php b/tests/DetectorTest/Detector9Test.php
@@ -23,6 +23,7 @@
 use BrowserDetector\Version\VersionBuilderFactoryInterface;
 use BrowserDetector\Version\VersionBuilderInterface;
 use BrowserDetector\Version\VersionInterface;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\TestCase;
 use Psr\Log\LoggerInterface;
@@ -43,6 +44,7 @@
 use UaResult\Os\Os;
 use UnexpectedValueException;
 
+#[CoversClass(Detector::class)]
 final class Detector9Test extends TestCase
 {
     /**

diff --git a/tests/DetectorTest/DetectorFactoryTest.php b/tests/DetectorTest/DetectorFactoryTest.php
@@ -15,6 +15,7 @@
 
 use BrowserDetector\Detector;
 use BrowserDetector\DetectorFactory;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\ExpectationFailedException;
 use PHPUnit\Framework\TestCase;
@@ -24,6 +25,7 @@
 
 use function assert;
 
+#[CoversClass(DetectorFactory::class)]
 final class DetectorFactoryTest extends TestCase
 {
     /**

diff --git a/tests/DetectorTest/DetectorTest.php b/tests/DetectorTest/DetectorTest.php
@@ -13,7 +13,9 @@
 
 namespace BrowserDetectorTest;
 
+use BrowserDetector\Detector;
 use BrowserDetector\DetectorFactory;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\ExpectationFailedException;
@@ -24,6 +26,7 @@
 use RuntimeException;
 use UnexpectedValueException;
 
+#[CoversClass(Detector::class)]
 final class DetectorTest extends TestCase
 {
     /**

diff --git a/tests/DetectorTest/Helper/DesktopTest.php b/tests/DetectorTest/Helper/DesktopTest.php
@@ -15,12 +15,14 @@
 
 use BrowserDetector\Helper\Desktop;
 use Override;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\ExpectationFailedException;
 use PHPUnit\Framework\TestCase;
 
 use function sprintf;
 
+#[CoversClass(Desktop::class)]
 final class DesktopTest extends TestCase
 {
     private Desktop $object;

diff --git a/tests/DetectorTest/Helper/MobileDeviceTest.php b/tests/DetectorTest/Helper/MobileDeviceTest.php
@@ -15,12 +15,14 @@
 
 use BrowserDetector\Helper\MobileDevice;
 use Override;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\ExpectationFailedException;
 use PHPUnit\Framework\TestCase;
 
 use function sprintf;
 
+#[CoversClass(MobileDevice::class)]
 final class MobileDeviceTest extends TestCase
 {
     private MobileDevice $object;

diff --git a/tests/DetectorTest/Helper/TvTest.php b/tests/DetectorTest/Helper/TvTest.php
@@ -15,12 +15,14 @@
 
 use BrowserDetector\Helper\Tv;
 use Override;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\ExpectationFailedException;
 use PHPUnit\Framework\TestCase;
 
 use function sprintf;
 
+#[CoversClass(Tv::class)]
 final class TvTest extends TestCase
 {
     private Tv $object;

diff --git a/tests/DetectorTest/Loader/BrowserLoaderTest.php b/tests/DetectorTest/Loader/BrowserLoaderTest.php
@@ -21,6 +21,7 @@
 use BrowserDetector\Version\VersionBuilderInterface;
 use Laminas\Hydrator\Strategy\StrategyInterface;
 use Override;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\ExpectationFailedException;
 use PHPUnit\Framework\TestCase;
@@ -31,6 +32,7 @@
 use UaLoader\Exception\NotFoundException;
 use UnexpectedValueException;
 
+#[CoversClass(BrowserLoader::class)]
 final class BrowserLoaderTest extends TestCase
 {
     /**

diff --git a/tests/DetectorTest/Loader/CompanyLoaderFactoryTest.php b/tests/DetectorTest/Loader/CompanyLoaderFactoryTest.php
@@ -16,11 +16,13 @@
 use BrowserDetector\Loader\CompanyLoaderFactory;
 use BrowserDetector\Loader\CompanyLoaderInterface;
 use Laminas\Hydrator\Strategy\StrategyInterface;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\ExpectationFailedException;
 use PHPUnit\Framework\TestCase;
 use RuntimeException;
 
+#[CoversClass(CompanyLoaderFactory::class)]
 final class CompanyLoaderFactoryTest extends TestCase
 {
     /**

diff --git a/tests/DetectorTest/Loader/CompanyLoaderTest.php b/tests/DetectorTest/Loader/CompanyLoaderTest.php
@@ -18,6 +18,7 @@
 use BrowserDetector\Loader\InitData\Company as DataCompany;
 use Laminas\Hydrator\Strategy\StrategyInterface;
 use Override;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\ExpectationFailedException;
 use PHPUnit\Framework\TestCase;
@@ -26,9 +27,7 @@
 use RuntimeException;
 use UaLoader\Exception\NotFoundException;
 
-/**
- * Test class for \BrowserDetector\Loader\CompanyLoader
- */
+#[CoversClass(CompanyLoader::class)]
 final class CompanyLoaderTest extends TestCase
 {
     /**

diff --git a/tests/DetectorTest/Loader/DeviceLoaderFactoryTest.php b/tests/DetectorTest/Loader/DeviceLoaderFactoryTest.php
@@ -15,13 +15,15 @@
 
 use BrowserDetector\Loader\CompanyLoaderInterface;
 use BrowserDetector\Loader\DeviceLoaderFactory;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\ExpectationFailedException;
 use PHPUnit\Framework\TestCase;
 use Psr\Log\LoggerInterface;
 use RuntimeException;
 use UaLoader\DeviceLoaderInterface;
 
+#[CoversClass(DeviceLoaderFactory::class)]
 final class DeviceLoaderFactoryTest extends TestCase
 {
     /**