Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: enable task delta cache #39307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

When there are many segment tasks in the querycoord scheduler, the traversal in GetSegmentTaskDelta checks becomes time-consuming. This PR adds caching for segment deltas.

issue: #37630

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 15, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 15, 2025
Copy link
Contributor

mergify bot commented Jan 15, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 15, 2025

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.08%. Comparing base (657550c) to head (72e67a2).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39307       +/-   ##
===========================================
+ Coverage   69.63%   81.08%   +11.44%     
===========================================
  Files         299     1406     +1107     
  Lines       26807   198396   +171589     
===========================================
+ Hits        18668   160861   +142193     
- Misses       8139    31883    +23744     
- Partials        0     5652     +5652     
Components Coverage Δ
Client 79.50% <ø> (∅)
Core 69.63% <ø> (ø)
Go 83.00% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/querycoordv2/task/scheduler.go 89.10% <100.00%> (ø)

... and 1106 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants